Repository navigation
feat(fio): check fio credentials on save and show the fio connection status - #542
Merged
Merged
Conversation
…status
- Profile form shows the backend's FIO error codes under their field and
"Connected" on success; account:fio_link_failed { reason }
- FIO status line on the profile and nav tag per fio_status (Active,
Syncing, Waiting for Data, Key Rejected, Inactive), non-active link to /profile
- userStore polls the profile every 15 s while syncing (max 5 min)
- Nav loads FIO storage only when the status is ok or error, which removes
the /data/storage/ 404 console errors
Spec: specs/2026-10-01-fio-credential-check.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for prunplanner-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jplacht
added a commit
that referenced
this pull request
Oct 1, 2026
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 32 |
| Duplication | 0 |
🟢 Coverage 100.00% diff coverage · +0.07% coverage variation
Metric Results Coverage variation ✅ +0.07% coverage variation (-1.00%) Diff coverage ✅ 100.00% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (d2b2277) 3529 3438 97.42% Head commit (e1cec69) 3544 (+15) 3455 (+17) 97.49% (+0.07%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#542) 15 15 100.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Wrong FIO keys and usernames used to be accepted silently, and the nav only said "FIO Inactive" with no reason. The profile form now shows why saving FIO credentials failed, and the nav and profile show the current FIO state from the backend's new
fio_status.Changes
UserProfileSchema:fio_status(enum) andfio_last_refreshed_at;userStore.fioStatus.account:fio_link_failed { reason }./profile.userStorere-fetches the profile every 15 s while the status issyncing(max 5 min), so Syncing turns Active without a reload.okorerror, which removes the/data/storage/404 console errors for users without data.How it was verified
QA PASS after three rounds: code review against the 11 acceptance criteria and a full e2e walk with a real FIO account (wrong key, mismatch, missing field, valid pair Syncing → Active in ~25 s without reload, rejected key, no data, collapsed nav).
pnpm test && pnpm tsc && pnpm lint && pnpm knippass, plus the component tests. UI audit: all pages at 5 viewports, no regressions versus baseline.Screenshots
The inline errors, Syncing and Key Rejected states were checked in the running app; their screenshots are left out because they showed a real FIO key.
Deploy order
Deploy backend first; it is backward compatible. Paired backend PR: PRUNplanner/backend#68
🤖 Generated with Claude Code